[PATCH] D66602: Add a LineTable class to GSYM and test it.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: include/llvm/DebugInfo/GSYM/FunctionInfo.h:70
+    LineTable = llvm::None;
+    Inline = llvm::None;
   }
----------------
Obviously it would be great if FunctionInfo itself could also be all-or-nothing (ie.. Optional).


================
Comment at: lib/DebugInfo/GSYM/LineTable.cpp:226
+                      SpecialOp)) {
+      // Advance the PC and line and push a row
+      Out.writeU8(SpecialOp);
----------------
.


================
Comment at: lib/DebugInfo/GSYM/LineTable.cpp:230
+      // We can't encode the address delta and line delta into
+      // a single special opcode, we must do them separately
+
----------------
.


================
Comment at: lib/DebugInfo/GSYM/LineTable.cpp:232
+
+      // Advance the line
+      if (LineDelta != 0) {
----------------
. (etc)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66602/new/

https://reviews.llvm.org/D66602