[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 21:15:11 PDT 2019


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: llvm/include/llvm/Demangle/Demangle.h:12
 
+#include "llvm/ADT/Optional.h"
 #include <cstddef>
----------------
MaskRay wrote:
> I'm not sure this is supported.
> 
> LLVMSupport depends on LLVMDemangle. LLVMDemangle probably shouldn't have any dependency on other components.
Hmm, good point.

I can do without the Optional here then, that form is only used in one place anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301





More information about the llvm-commits mailing list