[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.

Tue Sep 10 19:37:19 PDT 2019

MaskRay added a comment.

In D67301#1665171 <https://reviews.llvm.org/D67301#1665171>, @rnk wrote:

> In D67301#1664700 <https://reviews.llvm.org/D67301#1664700>, @MaskRay wrote:
>
> > I hope at least for ELF, you can keep the `"_Z"` prefix check. It doesn't need the ObjC `"___Z"` extension.
>
>
> Are you sure? Surely users could use `-fblocks` to get those manglings, or use ObjC on Linux.

We haven't even heard people complaining about lack of demangling of `__Z`, `___Z` or `___Z` prefixed names. I still lean towards keeping the `"_Z"` check for ELF to avoid false positive.

================
Comment at: llvm/include/llvm/Demangle/Demangle.h:12

+#include "llvm/ADT/Optional.h"
 #include <cstddef>
----------------
I'm not sure this is supported.

LLVMSupport depends on LLVMDemangle. LLVMDemangle probably shouldn't have any dependency on other components.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301