[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2649
+    assert(isValidState());
+    // TODO: add stats
+
----------------
remove the above three lines.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2670
+protected:
+  Optional<Value *> SimplifiedAssociatedValue;
+};
----------------
Add short documentation here please.


================
Comment at: llvm/test/Transforms/FunctionAttrs/value-simplify.ll:97
+end:
+  %phi-same = phi i32 [ 1, %if-true ], [ 1, %if-false ]
+  %phi-not-same = phi i32 [ 0, %if-true ], [ 1, %if-false ]
----------------
Could you make it (or add)
`%phi-same = phi i32 [ 1, %if-true ], [ %select-same, %if-false ]`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967