[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 10:06:54 PDT 2019


uenoku marked 8 inline comments as done.
uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2530
+               : ChangeStatus ::CHANGED;
+  }
+
----------------
jdoerfert wrote:
> `genericValueTraversal` above should deal with select and phi, correct? Do we have tests?
Add test in `@test-select-phi` in `value-simplify.ll`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967





More information about the llvm-commits mailing list