[PATCH] D67060: [Support] Add NestableWithColor

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 21:46:56 PDT 2019


MaskRay added a comment.

Reusing WithColor is also my preference. I think you can check who uses the third argument `DisableColors` of the following overload

  static raw_ostream &error(raw_ostream &OS, StringRef Prefix = "",
                            bool DisableColors = false);

and investigate if it is possible to change it to `WithColorContext *Context = nullptr` instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67060/new/

https://reviews.llvm.org/D67060





More information about the llvm-commits mailing list