[PATCH] D67060: [Support] Add NestableWithColor

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 02:08:20 PDT 2019


jhenderson added a comment.

In D67060#1654259 <https://reviews.llvm.org/D67060#1654259>, @ruiu wrote:

> Instead of adding a new class, do you think you can change the behavior of WithColor so that it restores the original colors instead of resetting it?


This would be my preference too, if it's viable. I don't think WithColor has been around that long, so I suspect it may be straightforward to identify existing usage patterns, and I'd be surprised if any expect restoration to default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67060/new/

https://reviews.llvm.org/D67060





More information about the llvm-commits mailing list