[PATCH] D66998: [yaml2obj] - Allow overriding sh_name fields of the sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 07:21:25 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:154
+  // This can be used to override the offset stored in the sh_name field.
+  // It does not affect the name stored in the string table
+  Optional<llvm::yaml::Hex64> ShName;
----------------
Nit: missing trailing full stop


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66998/new/

https://reviews.llvm.org/D66998





More information about the llvm-commits mailing list