[PATCH] D66998: [yaml2obj] - Allow overriding sh_name fields of the sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 07:15:22 PDT 2019


grimar added inline comments.


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:160
+
+  // This can be used to override the offset stored in sh_name field.
+  Optional<llvm::yaml::Hex64> ShName;
----------------
jhenderson wrote:
> in the sh_name
> 
> Perhaps worth mentioning that it does not affect the name stored in the string table.
>  it does not affect the name stored in the string table

I updated the test case to demonstrate this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66998/new/

https://reviews.llvm.org/D66998





More information about the llvm-commits mailing list