[PATCH] D66927: [Attributor] Implement AANoAliasCallSiteArgument initialization

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 11:39:36 PDT 2019


uenoku marked an inline comment as done.
uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1597
+    ImmutableCallSite ICS(&getAnchorValue());
+    if (ICS.paramHasAttr(getArgNo(), Attribute::NoAlias))
+      indicateOptimisticFixpoint();
----------------
jdoerfert wrote:
> can't u just say `hasAttr(` ? Some of the CallSite getters look at the argument, other do not.
I think `SubsumingPositionIterator` will look at associatedValue when given a callsite arugment. test11 below will fail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66927/new/

https://reviews.llvm.org/D66927





More information about the llvm-commits mailing list