[PATCH] D66927: [Attributor] Implement AANoAliasCallSiteArgument initialization

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 06:34:22 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Small nit, otherwise LGTM.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1597
+    ImmutableCallSite ICS(&getAnchorValue());
+    if (ICS.paramHasAttr(getArgNo(), Attribute::NoAlias))
+      indicateOptimisticFixpoint();
----------------
can't u just say `hasAttr(` ? Some of the CallSite getters look at the argument, other do not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66927/new/

https://reviews.llvm.org/D66927





More information about the llvm-commits mailing list