[PATCH] D66865: [DWARFVerifier] Verify new call site DWARF symbols

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 3 inline comments as done.
djtodoro added a comment.

@probinson Thanks a lot for your comments!



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:208
+  if (Die.getTag() != DW_TAG_call_site &&
+      Die.getTag() != DW_TAG_GNU_call_site)
     return 0;
----------------
probinson wrote:
> Adding GNU tags to existing functionality seems like it should be its own patch.
I could split this into two patches.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:530
+      // This might be reference to a function declaration.
+      if (DieTag == DW_TAG_GNU_call_site && RefTag == DW_TAG_subprogram)
+        break;
----------------
probinson wrote:
> Should this also check DW_TAG_call_site?
This only checks for the `DW_AT_abstract_origin` DWARF attribute that was used only by GNU call site extensions. After DWARF 5 Standard release, DW_TAG_call_site uses `DW_AT_call_origin` for the same purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66865/new/

https://reviews.llvm.org/D66865