[PATCH] D66865: [DWARFVerifier] Verify new call site DWARF symbols

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:208
+  if (Die.getTag() != DW_TAG_call_site &&
+      Die.getTag() != DW_TAG_GNU_call_site)
     return 0;
----------------
Adding GNU tags to existing functionality seems like it should be its own patch.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:230
+                 DW_AT_GNU_all_source_call_sites,
+                 DW_AT_GNU_all_tail_call_sites});
   if (!CallAttr) {
----------------
Adding GNU attributes to existing functionality seems like it should be its own patch.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:530
+      // This might be reference to a function declaration.
+      if (DieTag == DW_TAG_GNU_call_site && RefTag == DW_TAG_subprogram)
+        break;
----------------
Should this also check DW_TAG_call_site?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66865/new/

https://reviews.llvm.org/D66865