[PATCH] D63973: [MachineVerifier] Improve checks of target instructions operands.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 01:32:11 PDT 2019


jonpa requested review of this revision.
jonpa added a comment.

In D63973#1645986 <https://reviews.llvm.org/D63973#1645986>, @thegameg wrote:

> Thanks, this LGTM. I quickly looked at the X86 tests, it seems that `PATCHABLE_EVENT_CALL` and `PATCHABLE_TYPED_EVENT_CALL` are always created with a register but expect immediates in `Target.td`. I'm not sure what was the intention so I'll leave it to @dberris.


Thanks for review thegameg!  I am changing the status back to "Needs review", though, to avoid confusion...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63973/new/

https://reviews.llvm.org/D63973





More information about the llvm-commits mailing list