[PATCH] D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer

[Hideto Ueno via Phabricator via llvm-commits]

uenoku marked an inline comment as done.
uenoku added a comment.

In D65402#1645907 <https://reviews.llvm.org/D65402#1645907>, @jdoerfert wrote:

> I still think we should try to look only at (transitive) uses of the associated value instead of visiting all instructions and figuring out for each if it is interesting. You know what I mean?


Tracking transitive uses is also good to me but  I'm not sure there is an API to (efficiently) determine whether use of the associated value belongs to the context. Isn't it same to iterator over the instructions in the context?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:717
+      DoneFirstIteration = true;
+    }
+
----------------
jdoerfert wrote:
> Why can't we do this in the initialize?
In the `registerAA`, AA on-demand created may be overwritten. I'm not sure whether it is intended or bug. Then, I wanted to avoid to store the address of AAs in `initialize`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65402/new/

https://reviews.llvm.org/D65402