[PATCH] D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I still think we should try to look only at (transitive) uses of the associated value instead of visiting all instructions and figuring out for each if it is interesting. You know what I mean?



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:259
+                                            AllowNonInbounds);
   }
   /// Returns true if the GEP is based on a pointer to a string (array of
----------------
You can commit this separatly. It looks good to me.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:666
     return clampStateAndIndicateChange(
         S, static_cast<const typename AAType::StateType &>(AA.getState()));
   }
----------------
Make this just `StateType`


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:717
+      DoneFirstIteration = true;
+    }
+
----------------
Why can't we do this in the initialize?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65402/new/

https://reviews.llvm.org/D65402