[PATCH] D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files

Xing Xue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 18:29:25 PDT 2019


xingxue updated this revision to Diff 216751.
xingxue marked an inline comment as done.
xingxue added a comment.

Addressed comments:

- Changed the comment for variable `UseDotAlignForAlignment` as suggested.
- Replaced condition `GVKind.isBSS()` with `GVKind.isBSSLocal()`.
- Added a new line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66154/new/

https://reviews.llvm.org/D66154

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/include/llvm/MC/MCAsmInfo.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/MCAsmInfoXCOFF.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/MCSectionXCOFF.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66154.216751.patch
Type: text/x-patch
Size: 9836 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190823/01e7938a/attachment.bin>


More information about the llvm-commits mailing list