[PATCH] D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

A few small changes, but otherwise LGTM.



================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:168
 
+  /// True if .align is used for alignment of power of two instead .p2align.
+  bool UseDotAlignForAlignment = false;
----------------
Suggestion: "True if .align is to be used for alignment. Only power-of-two alignment is supported."


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1677
   const DataLayout &DL = GV->getParent()->getDataLayout();
-  unsigned Align =
+  // Handle common symbols.
+  if (GVKind.isCommon() || GVKind.isBSS()) {
----------------
Add a newline before the comment.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1678
+  // Handle common symbols.
+  if (GVKind.isCommon() || GVKind.isBSS()) {
+    unsigned Align =
----------------
I think this should be `isBSSLocal`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66154/new/

https://reviews.llvm.org/D66154