[PATCH] D65584: [ELF] Make binding (weak or non-weak) logic consistent for Undefined and SharedSymbol

Tue Aug 6 07:00:49 PDT 2019

MaskRay added a comment.

In D65584#1616759 <https://reviews.llvm.org/D65584#1616759>, @ruiu wrote:

> Honestly I don't have a strong preference on the behavior of weak symbols in this case. I have a slight concern that if there is a program that depends on the current behavior, they may break by this change, but this case is too subtle and linker-dependent, so I'm perhaps worried too much.
>
> LGTM

Don't worry! After the binding fix, the check is actually relaxed (weak undef doesn't error in lld while it may in a few scenarios in ld.bfd).

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65584/new/

https://reviews.llvm.org/D65584