[PATCH] D65584: [ELF] Make binding (weak or non-weak) logic consistent for Undefined and SharedSymbol

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 05:55:25 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

Honestly I don't have a strong preference on the behavior of weak symbols in this case. I have a slight concern that if there is a program that depends on the current behavior, they may break by this change, but this case is too subtle and linker-dependent, so I'm perhaps worried too much.

LGTM


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65584/new/

https://reviews.llvm.org/D65584





More information about the llvm-commits mailing list