[PATCH] D65775: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 16:14:43 PDT 2019


devnexen updated this revision to Diff 213486.
devnexen added a comment.

Checking errno.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65775/new/

https://reviews.llvm.org/D65775

Files:
  compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp


Index: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp
===================================================================
--- compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp
+++ compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp
@@ -72,7 +72,11 @@
 #ifdef MADV_NOHUGEPAGE  // May not be defined on old systems.
   if (common_flags()->no_huge_pages_for_shadow)
     return madvise((char *)addr, size, MADV_NOHUGEPAGE) == 0;
-  return true;
+  int r = madvise((char *)addr, size, MADV_HUGEPAGE) == 0;
+  int rerrno = 0;
+  if (internal_iserror(r, &rerrno) && rerrno == EINVAL)
+    return false;
+  return r == 0;
 #else
   return true;
 #endif  // MADV_NOHUGEPAGE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65775.213486.patch
Type: text/x-patch
Size: 700 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190805/dbc24423/attachment.bin>


More information about the llvm-commits mailing list