[PATCH] D65775: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:37:12 PDT 2019


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp:75
     return madvise((char *)addr, size, MADV_NOHUGEPAGE) == 0;
-  return true;
+  return madvise((char *)addr, size, MADV_HUGEPAGE) == 0;
 #else
----------------
I suspect it's going to fail if THP is "never"? If true, tsan will crash.
can you check madvise result and errno for such case?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65775/new/

https://reviews.llvm.org/D65775





More information about the llvm-commits mailing list