[PATCH] D65291: [RISCV] Add Custom Parser for Atomic Memory Operands

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 05:25:24 PDT 2019


asb resigned from this revision.
asb added a comment.
Herald added a subscriber: asb.

Thanks for looking at an alternate approach here James. In light of the better error messages I'm going to go with D65205 <https://reviews.llvm.org/D65205> at this point, but I'm open to future refactoring or improvements. I haven't spent a lot of time considering it, but my initial reaction on PushParens is I feel it might make the parsing logic harder to follow in return for a fairly minor reduction in repetition. But I could be convinced otherwise...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65291/new/

https://reviews.llvm.org/D65291





More information about the llvm-commits mailing list