[PATCH] D65291: [RISCV] Add Custom Parser for Atomic Memory Operands

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

I've taken a look at this patch and am largely happy with it, except that I think it gives worse error messages than D65205 <https://reviews.llvm.org/D65205> for invalid operands (compare `llvm/test/MC/RISCV/rv64a-invalid.s` and `llvm/test/MC/RISCV/rv32a-invalid.s` between the two patches).

@asb is currently away for a few days, but in discussions we've had, it seems likely we'll err towards merging D65205 <https://reviews.llvm.org/D65205>. This should happen soon, as we want this and the patch that depends on this backported to the 9.0 branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65291/new/

https://reviews.llvm.org/D65291