[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 10:22:43 PDT 2019


Hi,

Apologies for the ambiguity. My mail was intended to convey that I don't
believe extractvalue should ever be considered non-free. But I am not 100%
sure there don't exist counterexamples I haven't considered.

Cheers,

James

On Tue, 30 Jul 2019, 17:39 Roman Lebedev via Phabricator, <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added a comment.
>
> > @jmolloy (via mail)
> >  > `extractvalue` from `@llvm.with.overflow` specifically?
> >  Is there a situation in which *any* extractvalue generates code?
> structs have to be SROA'd into registers anyway, right?
>
> I don't know an answer to that question, thus i'm asking in the first
> place.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D65148/new/
>
> https://reviews.llvm.org/D65148
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190730/d4079ac0/attachment.html>


More information about the llvm-commits mailing list