[PATCH] D64685: ELF: Add support for remaining R_AARCH64_MOVW* relocations.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked 5 inline comments as done.
pcc added inline comments.


================
Comment at: lld/test/ELF/aarch64-relocs.s:242
+# CHECK-NEXT: 2100ac: 42 00 a0 d2  mov	x2, #131072
+## -65537 = 0xfffffffffffeffff
+# CHECK-NEXT: 2100b0: 22 00 a0 92  mov	x2, #-65537
----------------
MaskRay wrote:
> You can consider moving this chunk to a separate test and using `llvm-objdump -d --print-imm-hex`, then you don't have to explain `-65537 = 0xfffffffffffeffff`.
> 
> `x86-64-reloc-*.s` and `ppc32-reloc-*.s` are organized this way.
I think I'll leave this as is. The switch to `--print-imm-hex` would probably be better done as a cleanup over this entire file since there are already a number of instances of the same pattern here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64685/new/

https://reviews.llvm.org/D64685