[PATCH] D64685: ELF: Add support for remaining R_AARCH64_MOVW* relocations.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 02:51:19 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Arch/AArch64.cpp:260
+// to match the sign of the operand.
+static void writeSMovWImm(uint8_t *l, uint32_t imm) {
+  uint32_t inst = read32le(l);
----------------
As a single-letter variable, `l` is perhaps not a good name because it looks like 1. Maybe `loc`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64685/new/

https://reviews.llvm.org/D64685





More information about the llvm-commits mailing list