[PATCH] D64181: GlobalISel: moreElementsVector for G_LOAD

Fri Jul 12 17:43:34 PDT 2019

arsenm marked an inline comment as done.
arsenm added a comment.

In D64181#1584131 <https://reviews.llvm.org/D64181#1584131>, @dsanders wrote:

> The bit that's here LGTM. Is there another patch that implements moreElementsVectorSrc/moreElementsVectorDst?

Those have been around for a while, since around r354345

================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2562-2563
+  case TargetOpcode::G_LOAD: {
+    if (TypeIdx != 0)
+      return UnableToLegalize;
     Observer.changingInstr(MI);
----------------
dsanders wrote:
> Shouldn't we defend against this for the G_STORE case too?
Probably, although I'm not sure it makes sense to ever legalize the pointer operand

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64181/new/

https://reviews.llvm.org/D64181