[PATCH] D64181: GlobalISel: moreElementsVector for G_LOAD

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

The bit that's here LGTM. Is there another patch that implements moreElementsVectorSrc/moreElementsVectorDst?



================
Comment at: include/llvm/Target/GenericOpcodes.td:672
 
-// Generic load. Expects a MachineMemOperand in addition to explicit operands.
+// Generic load. Expects a MachineMemOperand in addition to explicit
+// operands. If the result size is larger than the memory size, the
----------------
Thanks for adding this.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2562-2563
+  case TargetOpcode::G_LOAD: {
+    if (TypeIdx != 0)
+      return UnableToLegalize;
     Observer.changingInstr(MI);
----------------
Shouldn't we defend against this for the G_STORE case too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64181/new/

https://reviews.llvm.org/D64181