[PATCH] D64290: [tools] [llvm-nm] Default to reading from stdin not a.out
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 11 22:51:16 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1756
+ if (Filename == "-" && sys::Process::StandardInIsUserInput()) {
+ WithColor::warning(errs(), ToolName) << "can't read from keyboard input.\n";
+ cl::PrintHelpMessage();
----------------
jhenderson wrote:
> Double-check this, but I'm pretty sure most warnings and errors don't end in a full-stop, so please remove it.
`keyboard input` -> `terminal`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64290/new/
https://reviews.llvm.org/D64290
More information about the llvm-commits
mailing list