[PATCH] D64290: [tools] [llvm-nm] Default to reading from stdin not a.out

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the two remaining comments addressed.



================
Comment at: llvm/test/tools/llvm-nm/stdin.test:7
+## Use passing an explicit filename as the baseline output. llvm-nm should
+## have the same behavior when opening a file itself and reading from its
+## standard input stream.
----------------
jhenderson wrote:
> and reading from -> "and reading that file from"
My bad, I should have said "and when..."


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1756
+  if (Filename == "-" && sys::Process::StandardInIsUserInput()) {
+    WithColor::warning(errs(), ToolName) << "can't read from keyboard input.\n";
+    cl::PrintHelpMessage();
----------------
Double-check this, but I'm pretty sure most warnings and errors don't end in a full-stop, so please remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64290/new/

https://reviews.llvm.org/D64290