[PATCH] D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: polly/include/polly/ScopInfo.h:2345
+  recorded_assumptions() {
+    return make_range(RecordedAssumptions.rbegin(), RecordedAssumptions.rend());
+  }
----------------
domada wrote:
> Meinersbur wrote:
> > Why reverse iterator? The user could also use `llvm::reverse`
> I was not aware of llvm::reverse function.
> 
> I needed reverse iterator for refactored addRecordedAssumptions function. I will fix this issue. Should I update review request or can I fix it when I will commit?
I do sometimes the diff with a "Update before commit (+ changes)" message; Phabricator 'complains' with a "Changed prior to commit:" line if it thinks the commit and the patch are not identical (but it's not reliable).

I'd say, update the review if you are unsure about how you resolved the pending comments, but it is not required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63572/new/

https://reviews.llvm.org/D63572