[PATCH] D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder

Dominik Adamski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 15:33:41 PDT 2019


domada added inline comments.


================
Comment at: polly/include/polly/ScopInfo.h:2345
+  recorded_assumptions() {
+    return make_range(RecordedAssumptions.rbegin(), RecordedAssumptions.rend());
+  }
----------------
Meinersbur wrote:
> Why reverse iterator? The user could also use `llvm::reverse`
I was not aware of llvm::reverse function.

I needed reverse iterator for refactored addRecordedAssumptions function. I will fix this issue. Should I update review request or can I fix it when I will commit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63572/new/

https://reviews.llvm.org/D63572





More information about the llvm-commits mailing list