[PATCH] D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...

Wed Jul 10 16:25:45 PDT 2019

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM with one change -- thanks!

================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:24
-class CompilationDatabase;
 struct CompileCommand;
 } // namespace tooling
----------------
looks like clang/Tooling/CompilationDatabase.h has this, too; please delete

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64541/new/

https://reviews.llvm.org/D64541