[PATCH] D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...

[Sterling Augustine via Phabricator via llvm-commits]

saugustine created this revision.
Herald added subscribers: llvm-commits, kadircet, arphaman, jkorous.
Herald added a project: LLVM.

...template argument.

Remove the forward declaration and include the appropriate header instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D64541

Files:
  clang-tools-extra/clangd/GlobalCompilationDatabase.h


Index: clang-tools-extra/clangd/GlobalCompilationDatabase.h
===================================================================
--- clang-tools-extra/clangd/GlobalCompilationDatabase.h
+++ clang-tools-extra/clangd/GlobalCompilationDatabase.h
@@ -11,6 +11,7 @@
 
 #include "Function.h"
 #include "Path.h"
+#include "clang/Tooling/CompilationDatabase.h"
 #include "llvm/ADT/Optional.h"
 #include "llvm/ADT/StringMap.h"
 #include <memory>
@@ -20,7 +21,6 @@
 namespace clang {
 
 namespace tooling {
-class CompilationDatabase;
 struct CompileCommand;
 } // namespace tooling
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64541.209091.patch
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190710/d50b1d5e/attachment.bin>