[PATCH] D64033: Add column info for inline sites

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 10:21:42 PDT 2019


JDevlieghere added a comment.

In D64033#1577696 <https://reviews.llvm.org/D64033#1577696>, @wenlei wrote:

> > @JDevlieghere once you sort out the odr-member-functions the patch is fine with me.  I am mildly curious why all three .o files got smaller.
>
> The original .o files were for MIPS, my updated ones are for x86_64 as I didn't build MIPS target, and I thought that's not important for what's being tested. I think that's the reason for the size difference.


I would have been very surprised if these object files were MIPS, and according to `otool` and `lipo` they're definitely x86_64. Anyway, like I said, if Paul agrees I don't think we need to update these.

  $ lipo  -info test/tools/dsymutil/Inputs/odr-member-functions/1.o
  Non-fat file: test/tools/dsymutil/Inputs/odr-member-functions/1.o is architecture: x86_64
  $ lipo  -info test/tools/dsymutil/Inputs/odr-member-functions/2.o
  Non-fat file: test/tools/dsymutil/Inputs/odr-member-functions/2.o is architecture: x86_64
  $ lipo  -info test/tools/dsymutil/Inputs/odr-member-functions/3.o
  Non-fat file: test/tools/dsymutil/Inputs/odr-member-functions/3.o is architecture: x86_64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64033/new/

https://reviews.llvm.org/D64033





More information about the llvm-commits mailing list