[PATCH] D64033: Add column info for inline sites

Wed Jul 10 00:03:08 PDT 2019

wenlei added a comment.

In D64033#1577463 <https://reviews.llvm.org/D64033#1577463>, @JDevlieghere wrote:

> In D64033#1577390 <https://reviews.llvm.org/D64033#1577390>, @probinson wrote:
>
> > I guess we can leave the .s file tests alone.  Most of them look like they were derived from real `-S` output and it would be pedantically consistent to update them, but they don't have to be.
> >  @JDevlieghere once you sort out the odr-member-functions the patch is fine with me.  I am mildly curious why all three .o files got smaller.
>
>
> I applied the patch and that obviously doesn't include the binaries, my bad. Do we need to regenerate these binaries at all? I'm tempted to just leave this test as-is.

These binaries are input for this test, so if we want to verify DW_AT_call_column, we'll need to update the input. But I agree that we don't have to, and I'm fine either way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64033/new/

https://reviews.llvm.org/D64033