[PATCH] D61597: [test-suite] Fix support for user mode emulation when using cmake/lit.

Wed Jul 10 01:51:32 PDT 2019

kristof.beyls added a comment.

In D61597#1577730 <https://reviews.llvm.org/D61597#1577730>, @lenary wrote:

> In D61597#1577701 <https://reviews.llvm.org/D61597#1577701>, @kristof.beyls wrote:
>
> > I wonder what the other issues are you're seeing after applying this patch?
> >  I also wonder if you've also tried the corresponding lnt patch at D61598 <https://reviews.llvm.org/D61598> that makes it possible to use this new functionality from `lnt runtest test-suite`?
>
>
> I don't think I've run into any further issues (that are the test-suite's fault) since applying your patch.
>
> Thanks for pointing me to that patch for LNT. I will see if it works for me. Until yesterday I was just invoking cmake directly, not via LNT, but now I need LNT's CSV-making powers.

FWIW, I also have a downstream patch for LNT to use comma as the separator, rather than semi-colon. I find that results in less clicking being needed when opening the CSV file in Excel. Happy to upstream that too if you also find out that commas, rather than semi-colons, as a field separator in CSV files works better.

> I'd be happy for this to land, but I don't know what else needs to be checked before it can.

I don't think anything else needs to be checked. It'd be great if the test-suite itself had a regression testing system as good as e.g. llvm or clang so that with regression tests even more confidence could be had in changes made. But that is an orthogonal issue.

Could you on this review mark that you've approved this patch ("Accept Revision")? Maybe you'll need to first make yourself a reviewer to be able to do that - I'm not sure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61597/new/

https://reviews.llvm.org/D61597