[PATCH] D61597: [test-suite] Fix support for user mode emulation when using cmake/lit.

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 01:13:14 PDT 2019


lenary added a comment.

In D61597#1577701 <https://reviews.llvm.org/D61597#1577701>, @kristof.beyls wrote:

> I wonder what the other issues are you're seeing after applying this patch?
>  I also wonder if you've also tried the corresponding lnt patch at D61598 <https://reviews.llvm.org/D61598> that makes it possible to use this new functionality from `lnt runtest test-suite`?


I don't think I've run into any further issues (that are the test-suite's fault) since applying your patch.

Thanks for pointing me to that patch for LNT. I will see if it works for me. Until yesterday I was just invoking cmake directly, not via LNT, but now I need LNT's CSV-making powers.

I'd be happy for this to land, but I don't know what else needs to be checked before it can.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61597/new/

https://reviews.llvm.org/D61597





More information about the llvm-commits mailing list