[PATCH] D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In D62455#1574256 <https://reviews.llvm.org/D62455#1574256>, @beanz wrote:

> I don't like the idea of putting this in `llvm_update_compile_flags`. That function does exactly what its name says, and adding additional behavior to it seems undesirable. Where are we creating libraries with `add_library` that we need this?


There might be others, but these are the ones I always see:

$ find llvm -type f \( -name "*.cmake" -o -name "*.txt" \) -exec grep -Hn llvm_update_compile_flags \{\} \;
llvm/tools/llvm-cfi-verify/lib/CMakeLists.txt:9:llvm_update_compile_flags(LLVMCFIVerify)
llvm/tools/llvm-exegesis/lib/CMakeLists.txt:38:llvm_update_compile_flags(LLVMExegesis)
llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt:11:llvm_update_compile_flags(LLVMExegesisPowerPC)
llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt:11:llvm_update_compile_flags(LLVMExegesisX86)
llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt:11:llvm_update_compile_flags(LLVMExegesisAArch64)

> One thought would be to make a new CMake function to apply the workaround.

Okay, I'll see if I can come up with something as clean as this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62455/new/

https://reviews.llvm.org/D62455