[PATCH] D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 13:21:07 PDT 2019


beanz added a comment.

I don't like the idea of putting this in `llvm_update_compile_flags`. That function does exactly what its name says, and adding additional behavior to it seems undesirable. Where are we creating libraries with `add_library` that we need this?

One thought would be to make a new CMake function to apply the workaround.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62455/new/

https://reviews.llvm.org/D62455





More information about the llvm-commits mailing list