[PATCH] D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed]

[Teresa Johnson via llvm-commits]

On Tue, Jul 2, 2019 at 1:49 PM Kostya Kortchinsky via Phabricator <
reviews at reviews.llvm.org> wrote:

> cryptoad added a comment.
>
> Regarding Teresa's issue, it seems to boil down to the version of clang,
> and not inlining the __atomic_load_8 & co.
> Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did
> it since a while.
> After attempting to conditionally add -latomic, and failing, I am
> resorting to adding -latomic unconditionally to the tests link flags,
> unless someone has a better idea.
>

This seems like the right solution (if not inlined for whatever reason, it
needs to be satisfied out of the library; if inlined, linking in the
library should not have any user visible impact).
Can you go ahead and commit that fix? I'm having to manually disable these
tests in all my clients for now.


>
> In D63831#1562747 <https://reviews.llvm.org/D63831#1562747>, @tejohnson
> wrote:
>
> > It passes if I link manually and add in -latomic. Should that be added
> to the link flags somewhere? How does this work on the bots or elsewhere?
>
>
>
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D63831/new/
>
> https://reviews.llvm.org/D63831
>
>
>
>

-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190703/a9e285a0/attachment.html>