[PATCH] D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed]

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 13:49:16 PDT 2019


cryptoad added a comment.

Regarding Teresa's issue, it seems to boil down to the version of clang, and not inlining the __atomic_load_8 & co.
Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did it since a while.
After attempting to conditionally add -latomic, and failing, I am resorting to adding -latomic unconditionally to the tests link flags, unless someone has a better idea.

In D63831#1562747 <https://reviews.llvm.org/D63831#1562747>, @tejohnson wrote:

> It passes if I link manually and add in -latomic. Should that be added to the link flags somewhere? How does this work on the bots or elsewhere?





Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63831/new/

https://reviews.llvm.org/D63831





More information about the llvm-commits mailing list