[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D63432#1568327 <https://reviews.llvm.org/D63432#1568327>, @davezarzycki wrote:

> Actually, the bug is narrower and doesn't require Swift (my build-and-test script placed the blame incorrectly). One just needs to build llvm+clang+lld after this change, then the following tests fail:
>
> Failing Tests (95):
>
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.SemanticsDeath
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.StringDecimalDeath
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.StringDecimalSignificandDeath
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.StringHexadecimalDeath
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.StringHexadecimalExponentDeath
>     LLVM-Unit :: ADT/./ADTTests/APFloatTest.StringHexadecimalSignificandDeath
>     LLVM-Unit :: ADT/./ADTTests/APIntTest.StringDeath
>     LLVM-Unit :: ADT/./ADTTests/APSIntTest.StringDeath
>     LLVM-Unit :: ADT/./ADTTests/AnyTest.BadAnyCast
>     LLVM-Unit :: ADT/./ADTTests/BumpPtrListTest.resetAlloc
>     LLVM-Unit :: ADT/./ADTTests/FallibleIteratorTest.RegularLoopExitRequiresErrorCheck
>     LLVM-Unit :: ADT/./ADTTests/PackedVectorTest.SignedValues
>     LLVM-Unit :: ADT/./ADTTests/PackedVectorTest.UnsignedValues
>     LLVM-Unit :: ADT/./ADTTests/STLExtrasTest.EarlyIncrementTest
>     LLVM-Unit :: AsmParser/./AsmParserTests/AsmParserTest.NonNullTerminatedInput
>     LLVM-Unit :: BinaryFormat/./BinaryFormatTests/MsgPackWriter.TestWriteCompatibleNoBin
>     LLVM-Unit :: CodeGen/./CodeGenTests/LowLevelTypeTest.ChangeElementTypeDeath
>     LLVM-Unit :: CodeGen/./CodeGenTests/MachineInstrBundleIteratorTest.CheckForBundles
>     LLVM-Unit :: IR/./IRTests/ConstantsTest.ReplaceWithConstantTest
>     LLVM-Unit :: IR/./IRTests/GlobalTest.AlignDeath
>     LLVM-Unit :: IR/./IRTests/ValueHandle.AssertingVH_Asserts
>     LLVM-Unit :: IR/./IRTests/ValueHandle.PoisoningVH_Asserts
>     LLVM-Unit :: IR/./IRTests/ValueHandle.TrackingVH_Asserts
>     LLVM-Unit :: IR/./IRTests/ValueTest.getLocalSlotDeath
>     LLVM-Unit :: Support/./SupportTests/CommandLineTest.TokenizeWindowsCommandLine2
>     LLVM-Unit :: Transforms/Utils/./UtilsTests/ValueMapperTest.mapMetadataLocalAsMetadata
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2Avx512TargetTest.FillMemoryOperands_ADD64rm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2Avx512TargetTest.FillMemoryOperands_VGATHERDPSZ128rm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2Avx512TargetTest.SetRegToVR128Value_Use_VMOVDQU32Z128rm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2Avx512TargetTest.SetRegToVR256Value_Use_VMOVDQU32Z256rm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2Avx512TargetTest.SetRegToVR512Value
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2AvxTargetTest.SetRegToVR128Value_Use_VMOVDQUrm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2AvxTargetTest.SetRegToVR256Value_Use_VMOVDQUYrm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.NoHighByteRegs
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetFlags
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToFP0_80Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToFP1_32Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToFP1_4Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToGR16Value
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToGR32Value
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToGR64Value
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToGR8Value
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToST0_32Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToST0_64Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToST0_80Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToST1_32Bits
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToVR128Value_Use_MOVDQUrm
>     LLVM-Unit :: tools/llvm-exegesis/X86/./LLVMExegesisX86Tests/Core2TargetTest.SetRegToVR64Value
>     Clang :: CodeCompletion/macros-in-modules.c
>     Clang :: CodeCompletion/macros-in-modules.m
>     Clang :: CodeCompletion/pch-and-module.m
>     Clang :: Driver/crash-report-modules.m
>     Clang :: Driver/modules-cache-path.m
>     Clang :: Driver/modules.m
>     Clang :: Driver/modules.mm
>     Clang :: Driver/split-debug.h
>     Clang :: Index/Core/index-with-module.m
>     Clang :: Index/annotate-comments-objc.m
>     Clang :: Index/annotate-module.m
>     Clang :: Index/complete-module-undef.m
>     Clang :: Index/complete-modules.m
>     Clang :: Index/crash-recovery-modules.m
>     Clang :: Index/index-module-with-vfs.m
>     Clang :: Index/index-module.m
>     Clang :: Index/index-pch-with-module.m
>     Clang :: Index/modules-objc-categories.m
>     Clang :: Index/pch-depending-on-deleted-module.c
>     Clang :: Index/pch-with-module.m
>     Clang :: Index/preamble-with-implicit-import.m
>     Clang :: Index/retain-comments-from-system-headers.c
>     Clang :: Modules/crash-vfs-path-emptydir-entries.m
>     Clang :: Modules/crash-vfs-path-symlink-component.m
>     Clang :: Modules/crash-vfs-path-symlink-topheader.m
>     Clang :: Modules/crash-vfs-path-traversal.m
>     Clang :: Modules/crash-vfs-relative-overlay.m
>     Clang :: Modules/crash-vfs-umbrella-frameworks.m
>     Clang :: Modules/driver.c
>     Clang :: Modules/fatal-module-loader-error.m
>     Clang :: Modules/import-decl.cpp
>     Clang :: Modules/module-imported-by-pch-path.m
>     Clang :: Modules/self-import-header.m
>     Clang :: Modules/serialized-diags.m
>     Clang :: Modules/subdirectory-module-maps-working-dir.m
>     Clang :: Modules/umbrella-header-include-builtin.mm
>     Clang :: VFS/real-path-found-first.m
>     Clang-Unit :: ASTMatchers/./ASTMatchersTests/HasNameDeathTest.DiesOnEmptyName
>     Clang-Unit :: ASTMatchers/./ASTMatchersTests/HasNameDeathTest.DiesOnEmptyPattern
>     Clang-Unit :: ASTMatchers/./ASTMatchersTests/IsDerivedFromDeathTest.DiesOnEmptyBaseName
>     Clang-Unit :: ASTMatchers/Dynamic/./DynamicASTMatchersTests/VariantValueTest.Matcher
>     Clang-Unit :: Lex/./LexTests/LexerTest.DontOverallocateStringifyArgs
>     Clang-Unit :: Serialization/./SerializationTests/InMemoryModuleCacheTest.addBuiltPCM
>     Clang-Unit :: Serialization/./SerializationTests/InMemoryModuleCacheTest.addPCM
>     Clang-Unit :: Serialization/./SerializationTests/InMemoryModuleCacheTest.initialState
>     Clang-Unit :: Serialization/./SerializationTests/InMemoryModuleCacheTest.tryToDropPCM
>     Clang-Unit :: libclang/./libclangTests/LibclangReparseTest.ReparseWithModule
>   
>   Expected Passes    : 34914
>   Expected Failures  : 71
>   Unsupported Tests  : 14478
>   Unexpected Failures: 95


Can you share your simplified build/test instructions? I don't find evidence from other buildbots so I'm not sure this change is the culprit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432