[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In D63432#1568294 <https://reviews.llvm.org/D63432#1568294>, @davezarzycki wrote:

> This change breaks a ton of clang tests, albeit in the Swift fork of clang. Was this expected? If not, can we revert this for now?
>
> I've confirmed that reverting this change allows top-of-tree LLVM+clang+lld to build/test top-of-tree Swift (with forks of llvm, clang, etc)


It wasn't expected. Those tests don't seem to be reliant on a specific output in the binary so it looks suspiciously like clang, libclang.so etc are being linked incorrectly. In theory this should get caught by http://lab.llvm.org:8011/builders/clang-lld-x86_64-2stage/builds/8556 (still at build-stage 2). If that fails then there is a good case to revert the change for further investigation.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432