[PATCH] D54815: [ThinLTO] Add summary entries for index-based WPD

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:896
+  /// above where TypeIdCompatibleVtableInfo is defined.
+  std::map<std::string, TypeIdCompatibleVtableInfo> TypeIdCompatibleVtableMap;
+
----------------
Prazek wrote:
> tejohnson wrote:
> > Prazek wrote:
> > > Do we care about the alphabetical order in this mapping?
> > > If not, the map can be changed to std::unordered_map (or other llvm-specific string map), which should be faster and more memory efficient.
> > We care about consistent ordering, as the iteration order will affect the order of the summary entries emitted into the bitcode. So unordered_map is not appropriate here. Ditto for StringMap.
> That's what I thought, sorry for late review and thanks for fixing other nits :)
No prob, thanks for the comments. Committed fixes in r364968


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54815/new/

https://reviews.llvm.org/D54815