[PATCH] D64094: CodeGen: Set hasSideEffects = 0 on BUNDLE

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 12:43:29 PDT 2019


arsenm created this revision.
arsenm added reviewers: qcolombet, aemerson, marcello.maggioni, volkan.
Herald added subscribers: tpr, javed.absar, nhaehnle, wdng, jvesely.

The BUNDLE itself should not have side effects, and this is a property
of instructions inside the bundle. The hasProperty check already
 searches for any member instructions, which was pointless since it was
overridden by this bit.

      

Allows me to distinguish bundles that have side effects vs. do not in
 a future patch. Also fixes an unnecessary scheduling barrier in the
bundle AMDGPU uses to get PC relative addresses.


https://reviews.llvm.org/D64094

Files:
  include/llvm/Target/Target.td
  test/CodeGen/AMDGPU/byval-frame-setup.ll
  test/CodeGen/AMDGPU/call-argument-types.ll
  test/CodeGen/AMDGPU/call-preserved-registers.ll
  test/CodeGen/AMDGPU/call-waitcnt.ll
  test/CodeGen/AMDGPU/sibling-call.ll
  test/CodeGen/ARM/Windows/tls.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64094.207608.patch
Type: text/x-patch
Size: 14774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190702/e1be027b/attachment.bin>


More information about the llvm-commits mailing list