[PATCH] D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics

[Yury Delendik via Phabricator via llvm-commits]

yurydelendik added a comment.

In D58453#1564940 <https://reviews.llvm.org/D58453#1564940>, @jmorse wrote:

> Hi,
>
> Awkwardly collectDebugValues relies on a behaviour that this patch will mostly undo, specifically, that DBG_VALUE insts are placed after the defining instruction. collectDebugValues will work sometimes, but will "miss" DBG_VALUEs much more often that it does now.


I was counting on "collectDebugValues will work sometimes" part and still hoping it will perform with some degree to "finding" most of the related DBG_VALUEs in the current block.

> We can tailor something to suit WebAssemblys needs: would it be OK if collectDebugValues returned _all_ DBG_VALUE uses of the virtual register it's called on/with? That would include, for example, debug uses from different basic blocks, which doesn't occur with the current collectDebugValues implementation.

Agree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58453/new/

https://reviews.llvm.org/D58453