[PATCH] D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Hi,

In D58453#1564358 <https://reviews.llvm.org/D58453#1564358>, @yurydelendik wrote:

> The change will be OK: we rely on collectDebugValues in WebAssembly to locate instruction's debug values. And we worry only about these atm.


Awkwardly collectDebugValues relies on a behaviour that this patch will mostly undo, specifically, that DBG_VALUE insts are placed after the defining instruction. collectDebugValues will work sometimes, but will "miss" DBG_VALUEs much more often that it does now.

We can tailor something to suit WebAssemblys needs: would it be OK if collectDebugValues returned _all_ DBG_VALUE uses of the virtual register it's called on/with? That would include, for example, debug uses from different basic blocks, which doesn't occur with the current collectDebugValues implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58453/new/

https://reviews.llvm.org/D58453