[PATCH] D63058: [InlineCost] Fix bug 42084: return the first negative result

Fri Jun 21 01:41:19 PDT 2019

yrouban added a comment.

In D63058#1545596 <https://reviews.llvm.org/D63058#1545596>, @fedor.sergeev wrote:

> In D63058#1543122 <https://reviews.llvm.org/D63058#1543122>, @yrouban wrote:
>
> > One issue bothers me: results of the InlineCost analyzer will depend on the flag //ComputeFullInlineCost//. Negative or positive decision will persist but the message and highest computed cost will be changing.
>
>
> We already have the cost difference depending on this flag.
>  It seems to be rather obvious consequence of "full inline cost" notion and the difference should not be confusing...

I still believe that we should separate a bug fix from introducing a new feature. As I read the comments this patch looks to be complex to be just a bugfix but not full enough to introduce a new and complete feature.
I could provide a one line fix with a test if I believe it is a complete fix for the bug. In other words I'm a bit stuck. Any suggestions are welcome.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63058/new/

https://reviews.llvm.org/D63058